Skip to content

chore: Update admin references#1428

Merged
lantoli merged 2 commits intomasterfrom
CLOUDP-343569_admin
Sep 8, 2025
Merged

chore: Update admin references#1428
lantoli merged 2 commits intomasterfrom
CLOUDP-343569_admin

Conversation

@lantoli
Copy link
Copy Markdown
Member

@lantoli lantoli commented Sep 8, 2025

Proposed changes

Update admin references

Jira ticket: CLOUDP-343569

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@lantoli lantoli marked this pull request as ready for review September 8, 2025 15:38
Copilot AI review requested due to automatic review settings September 8, 2025 15:38
@lantoli lantoli requested a review from a team as a code owner September 8, 2025 15:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates package imports across the MongoDB Atlas CloudFormation resources to use aliased admin imports (e.g., admin20231115002 instead of bare admin) for better namespace management and version clarity.

  • Comprehensive import alias changes across all CloudFormation resource files
  • Addition of version-specific aliases for admin SDK imports
  • Consistent naming pattern using SDK version in alias names

Reviewed Changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cfn-resources/x509-authentication-database-user/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/third-party-integration/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/test/e2e/search-deployment/searchdeployment_test.go Updated admin import to use aliased admin20231115014
cfn-resources/test/e2e/project/project_test.go Updated admin import to use aliased admin20231115014
cfn-resources/test/e2e/cluster/cluster_test.go Updated admin import to use aliased admin20231115014
cfn-resources/teams/cmd/resource/team-user/team_user_test.go Updated admin import to use aliased admin20231115002
cfn-resources/teams/cmd/resource/team-user/team_user_service.go Updated admin import to use aliased admin20231115002
cfn-resources/teams/cmd/resource/team-user/team_user.go Updated admin import to use aliased admin20231115002
cfn-resources/teams/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/stream-instance/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/stream-instance/cmd/resource/mappings_test.go Updated admin import to use aliased admin20231115014
cfn-resources/stream-instance/cmd/resource/mappings.go Updated admin import to use aliased admin20231115014
cfn-resources/stream-connection/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/stream-connection/cmd/resource/mappings_test.go Updated admin import to use aliased admin20231115014
cfn-resources/stream-connection/cmd/resource/mappings.go Updated admin import to use aliased admin20231115014
cfn-resources/serverless-private-endpoint/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/serverless-instance/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/search-index/cmd/resource/resource_test.go Updated admin import to use aliased admin20231115002
cfn-resources/search-index/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/search-deployment/cmd/resource/state_transition_test.go Updated admin import to use aliased admin20231115014
cfn-resources/search-deployment/cmd/resource/state_transition.go Updated admin import to use aliased admin20231115014
cfn-resources/search-deployment/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/search-deployment/cmd/resource/mappings_test.go Updated admin import to use aliased admin20231115014
cfn-resources/search-deployment/cmd/resource/mappings.go Updated admin import to use aliased admin20231115014
cfn-resources/project/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/project/cmd/resource/mappings_test.go Updated admin import to use aliased admin20231115014
cfn-resources/project/cmd/resource/mappings.go Updated admin import to use aliased admin20231115014
cfn-resources/project-ip-access-list/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/project-ip-access-list/cmd/resource/list.go Updated admin import to use aliased admin20231115002
cfn-resources/project-invitation/cmd/resource/update.go Updated admin import to use aliased admin20231115002
cfn-resources/project-invitation/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/project-invitation/cmd/resource/list.go Updated admin import to use aliased admin20231115002
cfn-resources/project-invitation/cmd/resource/delete.go Updated admin import to use aliased admin20231115002
cfn-resources/project-invitation/cmd/resource/create.go Updated admin import to use aliased admin20231115002
cfn-resources/privatelink-endpoint-service-data-federation-online-archive/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/private-endpoint/cmd/resource/steps/privateendpointservice/private_endpoint_service.go Updated admin import to use aliased admin20231115002
cfn-resources/private-endpoint/cmd/resource/steps/privateendpoint/private_endpoint.go Updated admin import to use aliased admin20231115002
cfn-resources/private-endpoint/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/private-endpoint-service/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/private-endpoint-regional-mode/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/private-endpoint-aws/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/private-endpoint-adl/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/org-invitation/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/online-archive/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/network-peering/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/network-container/cmd/resource/update.go Updated admin import to use aliased admin20231115002
cfn-resources/network-container/cmd/resource/list.go Updated admin import to use aliased admin20231115002
cfn-resources/network-container/cmd/resource/create.go Updated admin import to use aliased admin20231115002
cfn-resources/maintenance-window/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/ldap-verify/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/ldap-configuration/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/global-cluster-config/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/federated-settings-org-role-mapping/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/federated-query-limit/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/federated-database-instance/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/encryption-at-rest/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/datalakes/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/data-lake-pipeline/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/custom-dns-configuration-cluster-aws/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/custom-db-role/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/cluster/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/cluster/cmd/resource/mappings_test.go Updated admin import to use aliased admin20231115014
cfn-resources/cluster/cmd/resource/mappings.go Updated admin import to use aliased admin20231115014
cfn-resources/cluster-outage-simulation/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/cloud-backup-snapshot/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/cloud-backup-snapshot-export-bucket/cmd/resource/resource.go Updated admin import to use aliased admin20231115002
cfn-resources/cloud-backup-schedule/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/cloud-backup-restore-jobs/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/auditing/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/api-key/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/alert-configuration/cmd/resource/resource.go Updated admin import to use aliased admin20231115014
cfn-resources/access-list-api-key/cmd/resource/resource.go Updated admin import to use aliased admin20231115014

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lantoli
Copy link
Copy Markdown
Member Author

lantoli commented Sep 8, 2025

contract tests for online-archive, serverless-private-endpoint and stream-connection are failing in master, execution link. Ticket created to address it: CLOUDP-343669

Copy link
Copy Markdown
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lantoli lantoli added this pull request to the merge queue Sep 8, 2025
Merged via the queue into master with commit c80ae58 Sep 8, 2025
53 of 60 checks passed
@lantoli lantoli deleted the CLOUDP-343569_admin branch September 8, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants