Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates package imports across the MongoDB Atlas CloudFormation resources to use aliased admin imports (e.g., admin20231115002 instead of bare admin) for better namespace management and version clarity.
- Comprehensive import alias changes across all CloudFormation resource files
- Addition of version-specific aliases for admin SDK imports
- Consistent naming pattern using SDK version in alias names
Reviewed Changes
Copilot reviewed 72 out of 72 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cfn-resources/x509-authentication-database-user/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/third-party-integration/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/test/e2e/search-deployment/searchdeployment_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/test/e2e/project/project_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/test/e2e/cluster/cluster_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/teams/cmd/resource/team-user/team_user_test.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/teams/cmd/resource/team-user/team_user_service.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/teams/cmd/resource/team-user/team_user.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/teams/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/stream-instance/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/stream-instance/cmd/resource/mappings_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/stream-instance/cmd/resource/mappings.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/stream-connection/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/stream-connection/cmd/resource/mappings_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/stream-connection/cmd/resource/mappings.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/serverless-private-endpoint/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/serverless-instance/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/search-index/cmd/resource/resource_test.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/search-index/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/search-deployment/cmd/resource/state_transition_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/search-deployment/cmd/resource/state_transition.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/search-deployment/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/search-deployment/cmd/resource/mappings_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/search-deployment/cmd/resource/mappings.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/project/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/project/cmd/resource/mappings_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/project/cmd/resource/mappings.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/project-ip-access-list/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/project-ip-access-list/cmd/resource/list.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/project-invitation/cmd/resource/update.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/project-invitation/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/project-invitation/cmd/resource/list.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/project-invitation/cmd/resource/delete.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/project-invitation/cmd/resource/create.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/privatelink-endpoint-service-data-federation-online-archive/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/private-endpoint/cmd/resource/steps/privateendpointservice/private_endpoint_service.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/private-endpoint/cmd/resource/steps/privateendpoint/private_endpoint.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/private-endpoint/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/private-endpoint-service/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/private-endpoint-regional-mode/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/private-endpoint-aws/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/private-endpoint-adl/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/org-invitation/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/online-archive/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/network-peering/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/network-container/cmd/resource/update.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/network-container/cmd/resource/list.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/network-container/cmd/resource/create.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/maintenance-window/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/ldap-verify/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/ldap-configuration/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/global-cluster-config/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/federated-settings-org-role-mapping/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/federated-query-limit/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/federated-database-instance/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/encryption-at-rest/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/datalakes/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/data-lake-pipeline/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/custom-dns-configuration-cluster-aws/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/custom-db-role/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/cluster/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/cluster/cmd/resource/mappings_test.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/cluster/cmd/resource/mappings.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/cluster-outage-simulation/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/cloud-backup-snapshot/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/cloud-backup-snapshot-export-bucket/cmd/resource/resource.go | Updated admin import to use aliased admin20231115002 |
| cfn-resources/cloud-backup-schedule/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/cloud-backup-restore-jobs/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/auditing/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/api-key/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/alert-configuration/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
| cfn-resources/access-list-api-key/cmd/resource/resource.go | Updated admin import to use aliased admin20231115014 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
contract tests for online-archive, serverless-private-endpoint and stream-connection are failing in master, execution link. Ticket created to address it: CLOUDP-343669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update admin references
Jira ticket: CLOUDP-343569
Link to any related issue(s):
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments