Repository navigation
Diskless implementation presets: inkless-3az, kafscale-3b, automq-3az and DB/ET codes (v2.3) - #8
Merged
Merged
Conversation
… and the DB/ET control-plane codes (v2.3)
The simulator's v2.3 free play adds three diskless implementation presets,
and the website's sim-link docs already describe them as build_playground_url
cluster values. sim-link refused all three ("not a free-play topology").
This brings it to parity with the playground's own codec:
- mcpserver shape: cluster takes inkless-3az (6x3x3, orders classic, clicks
diskless), kafscale-3b (3x3x1) and automq-3az (3x6x1), with the shared
multi-DC caps. On kafscale-3b and automq-3az every topic is diskless at
RF 1: an RF above 1 or a compacted topic is refused, and an extra topic
gets the "~1" the playground writes for it. kafscale-3b refuses
disklessTiming.commitIntervalMs (KafScale has no commit interval). The
primary diskless flag is never written on these presets, and
disklessEnable on inkless-3az's orders is refused, since the playground
drops both. A caller topic named like a preset's own (clicks on
diskless-3az and inkless-3az) is refused instead of silently renamed.
- actionlog: StopCoordinatorDB/StartCoordinatorDB (DB:0/DB:1, Inkless
PostgreSQL) and StopEtcd/StartEtcd (ET:0/ET:1, KafScale etcd) encode and
decode with the playground's wire form; any other payload is an error.
- mcpserver actions: build_playground_url accepts stop_coordinator_db,
start_coordinator_db, stop_etcd and start_etcd and echoes them back.
- SIZE-IMPL fixtures dumped from the real TypeScript codec
(decodeFreePlaySize/encodeFreePlaySize per preset) pin the slugs;
docs/mapping.md and the README describe the presets and codes.
The AutoMQ zone router has no shape input, as the docs already say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The simulator's v2.3 free play has three diskless implementation presets, and the website's sim-link MCP docs (reference/mcp-tools.mdx, in a "from v2.3" block) already list them as
build_playground_urlclustervalues, withDB:0/DB:1for Inkless. sim-link refused all three with "not a free-play topology". This PR brings it to parity with the playground's own codec.Shape:
clusternow takes these three presets:inkless-3az(default6x3x3):ordersclassic,clicksdisklesskafscale-3b(default3x3x1)automq-3az(default3x6x1)All three use the shared multi-DC caps of 9 brokers and 6 partitions. Each rule below mirrors
freePlayTopologies.ts:~1field even when the caller did not set it, because the playground writes it.disklessTiming.commitIntervalMsis refused, because KafScale has no commit interval.dis never written on these presets, since the playground drops it.disklessEnableonordersis refused.clicksondiskless-3azorinkless-3azis refused. Before, the playground silently renamed it.actionlog: adds
DB:0/DB:1(stop and start the Inkless PostgreSQL) andET:0/ET:1(stop and start the KafScale etcd). A payload other than0or1is an error.MCP actions: adds
stop_coordinator_db,start_coordinator_db,stop_etcdandstart_etcd. They are encoded into the URL and echoed back.The AutoMQ zone router still has no shape input, as the docs already say.
Files changed
mcpserver/shape.go: the three topologies,impl/fixedTopics, and the RF, compaction, timing and primary-flag rulesmcpserver/actions.go,mcpserver/mcpserver.go: the four action kinds and the tool and schema descriptionsactionlog/actions.go,actionlog/decode.go,actionlog/actionlog.go: the DB and ET codesmapping/testdata/ts-fixtures.txt: 16SIZE-IMPLlines, made withdecodeFreePlaySize/encodeFreePlaySizeper preset from website maine9bf8e22mcpserver/shape_test.go,mcpserver/mcpserver_test.go,actionlog/actionlog_test.go,actionlog/property_test.godocs/mapping.md,README.mdCommands run
gofmt -lon the changed files: cleango vet ./...andgo vet -tags e2e ./e2e/: cleango test ./...: all packages pass, including the newTestShapeImplMatchesTypeScriptFixtures,TestShapeImplPresets,TestShapeImplValidation,TestBuildURLDisklessControlPlanesandTestDisklessControlPlaneWireconnect) is untouched. CI runs both.Known risks
automq-3azis refused, although AutoMQ supports it. The playground would accept the slug, but the simulator's engine does not model compacted topics there, so refusing it is the conservative choice. The error message says that the gap is in the simulator.clicksondiskless-3azis now refused. Before, the URL loaded with the topic renamed toclicks-2. This is a small behavior change for an existing preset.clustervalues fall back to single-dc and the DB/ET codes are dropped. This is the same behavior as for other new codes.Follow-up
stop_etcd/start_etcdcould be added there next tokafscale-3b.🤖 Generated with Claude Code