Repository navigation
fix(operator): ACLConflict messages say the Deny is applied - #47
Merged
Merged
Conversation
Since 1.1.0 an Allow/Deny conflict resolves to the Deny, but the ACLConflict condition and the KafkaAccessPolicy webhook rejection still said the whole tuple was dropped from the applied set. The condition now names which side this resource holds and says the Deny is applied and the Allow is not; the webhook says the operator would apply the Deny.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since 1.1.0, a cross-resource Allow/Deny conflict on one ACL tuple resolves to the Deny: it's sorted first and survives first-seen-wins. Two user-facing messages still described the old behaviour, saying the whole tuple was "dropped from the applied set":
ACLConflictcondition (CrossResourceConflict): the message now names which side this resource holds and says the Deny is applied and the Allow is not. For example:ACL <subject>: this resource's Allow conflicts with the Deny from KafkaAccessPolicy/ns1/p1 on the same tuple; the Deny is applied and the Allow is not.KafkaAccessPolicywebhook rejection: now says the operator would apply the Deny and drop the Allow.BuildClusterACLViewandsetACLConflictConditionupdated to match.There's no behaviour change. The website docs (monedula-dev/monedula-website#974) already describe the Deny-wins behaviour.
Checklist
go build ./...,go vet ./...,go test ./...pass. The condition tests now also check the per-side wording.CHANGELOG.md(Unreleased) if user-facing