Skip to content

fix(operator): ACLConflict messages say the Deny is applied - #47

Merged
mmatloka merged 1 commit into
mainfrom
fix/aclconflict-message
Nov 21, 2026
Merged

mmatloka merged 1 commit into
mainfrom
fix/aclconflict-message

Conversation

@mmatloka

Copy link
Copy Markdown
Contributor

Summary

Since 1.1.0, a cross-resource Allow/Deny conflict on one ACL tuple resolves to the Deny: it's sorted first and survives first-seen-wins. Two user-facing messages still described the old behaviour, saying the whole tuple was "dropped from the applied set":

  • ACLConflict condition (CrossResourceConflict): the message now names which side this resource holds and says the Deny is applied and the Allow is not. For example: ACL <subject>: this resource's Allow conflicts with the Deny from KafkaAccessPolicy/ns1/p1 on the same tuple; the Deny is applied and the Allow is not.
  • KafkaAccessPolicy webhook rejection: now says the operator would apply the Deny and drop the Allow.
  • Doc comments: BuildClusterACLView and setACLConflictCondition updated to match.

There's no behaviour change. The website docs (monedula-dev/monedula-website#974) already describe the Deny-wins behaviour.

Checklist

  • go build ./..., go vet ./..., go test ./... pass. The condition tests now also check the per-side wording.
  • Updated CHANGELOG.md (Unreleased) if user-facing
  • Behavior or usage changes are noted in the summary, so the docs at https://monedula.dev/flock/docs/gitops/ can follow

Since 1.1.0 an Allow/Deny conflict resolves to the Deny, but the
ACLConflict condition and the KafkaAccessPolicy webhook rejection still
said the whole tuple was dropped from the applied set. The condition now
names which side this resource holds and says the Deny is applied and
the Allow is not; the webhook says the operator would apply the Deny.
@mmatloka
mmatloka merged commit 65b78c1 into main Nov 21, 2026
15 checks passed
@mmatloka
mmatloka deleted the fix/aclconflict-message branch November 21, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant