Repository navigation
fix(security): Go 1.26.11, Secret opt-in and tenancy hardening - #41
Merged
Merged
Conversation
- Bump the Go minimum to 1.26.11 and update all dependencies. - Run the quickstart, scenario and webhook manifests as non-root with dropped capabilities. - Tenancy: empty prefixes fail closed; Schema Registry subjects are checked against tenancy prefixes. - Finalizers only clean up specs the operator applied and the namespace is still allowed to manage. - Cluster ACL view: Allow/Deny conflicts resolve to Deny, and prune scope covers every policy. - BREAKING: referenced Secrets must carry the label gitops.monedula.dev/credential-source=true (opt out with --require-secret-label=false / requireSecretLabel: false). - Optional --secret-namespaces / rbac.secretNamespaces replaces cluster-wide Secret RBAC with per-namespace Roles.
gkocur
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Go minimum to 1.26.11 and updates all dependencies. Also fixes a batch of security-scanner findings in three areas: cross-tenant isolation, containers running as root, and access control.
Dependencies
go 1.26.11; all modules updated, including franz-go, grpc, otel and k8s.io v0.37.2.k8s.io/kube-openapiis pinned to a revision that still supports Go 1.26. The latest revision requires Go 1.27.Tenancy / isolation
""prefixes because they match every name.TenancyDeniedand is never deleted.CleanupSkippedevent. This stops spec edits made during deletion from triggering cleanup on behalf of another tenant.Secrets
gitops.monedula.dev/credential-source=true. This covers KafkaCluster credentials and TLS, KafkaTopic schema bodies and KafkaUser passwords. You can opt out with--require-secret-label=falseor chartrequireSecretLabel: false. The CHANGELOG has an upgrade note.--secret-namespacesflag (chart:rbac.secretNamespaces). When set, the ClusterRole drops all Secret access and each listed namespace gets its own Role and RoleBinding. The Secret cache and reads are limited to those namespaces.Non-root manifests
runAsNonRootand a fixed UID/GID. They also use seccompRuntimeDefault, disallow privilege escalation and dropALLcapabilities.Reviewer notes
metadata.generationby 1 when it setsdeletionTimestamp. The "spec was applied" check therefore acceptsobserved+1.Checklist
go build ./...,go vet ./...,go test ./...pass. The envtest suites and the helm render tests andhelm lintalso pass, run in a Linux container. The kind e2e suite has not been run locally.CHANGELOG.md(Unreleased) if user-facing