Repository navigation
test(matrix): wait until broker serves requests before returning it - #40
Merged
Merged
Conversation
The containers' log-based readiness ("Transitioning from RECOVERY to
RUNNING" / "Kafka Server started") can fire just before the client
listener processes requests. A client connecting in that window has the
connection closed during ApiVersions negotiation, which franz-go reports
as "is TLS missing?". This failed TestIntegration_Converge on the
cp-8.0 cell on main.
StartBroker now pings the broker on its host-reachable listener (up to
60s) for both families before handing it to the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cion main (after test(webhook): fix envtest cache race behind flaky main CI #39) failed inintegration (cp-8.0):TestIntegration_Convergegotbroker closed the connection immediately during api versions negotiation ... is TLS missing?right after the container was reported ready. The other six cells passed, and the same commit was green on the PR.Transitioning from RECOVERY to RUNNINGfor Confluent,Kafka Server startedfor Apache), and that can fire a moment before the client listener processes requests. Not a TLS issue, and not caused by the testcontainers kafka 0.45.0 bump (build(deps): bump github.com/testcontainers/testcontainers-go/modules/kafka from 0.44.0 to 0.45.0 #35), which only adds opt-in TLS and leaves the wait strategy unchanged.matrix.StartBrokernow pings the broker on its host-reachable listener (retry every 250ms, up to 60s) for both families before returning it. If the broker never serves, the container is terminated and the error says so. This covers every integration and e2e test that starts a broker.Test plan
go vet -tags integration/-tags e2eoninternal/matrix,internal/kafka/franz