fix: InputType.HIDDEN no longer renders a visible label (#14) - #28
Open
jannikbx wants to merge 2 commits into
Open
fix: InputType.HIDDEN no longer renders a visible label (#14)#28jannikbx wants to merge 2 commits into
jannikbx wants to merge 2 commits into
Conversation
Hidden inputs should render as bare <input type="hidden"> elements without a <label> or error container, since both are invisible and meaningless for hidden form fields. Closes mondi04#14
Hidden inputs should render as bare <input type="hidden"> elements without a <label> or error container, since both are invisible and meaningless for hidden form fields. Closes mondi04#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14 —
InputType.HIDDENform fields no longer render a visible<label>or error<div>. Hidden inputs are now rendered as bare<input type="hidden">elements.✅ Commits are GPG signed
Changes
htmforge/components/form_field.py: Add early return inrender()forInputType.HIDDEN— skips label and error container, returns only the control elementtests/test_components.py: Add two new test cases:test_hidden_input_renders_no_label_or_error— verifies bare hidden input without label/errortest_hidden_input_with_error_still_no_label— verifies error text is not rendered even when setBefore
After
Test Results