Repository navigation
feat: release v1.1.0 with typed getters, fake store and hardened bridge - #1
Merged
Merged
Conversation
Settings resolve through a SettingsStore driver: native bridge on device, file or array store locally and in tests. Settings::fake() swaps in an in-memory store for assertions.
Typed getters (bool, int, float, string, array, enum) return the default on type mismatch. all() skips corrupted entries and allWithReport() exposes what was skipped.
Native readers skip entries they cannot decode instead of failing the whole map, and read the v2 storage format.
Bridge errors surface as SettingsBridgeError. Reserved keys are rejected. set and forget resolve undefined. Adds settings.d.ts.
Adds CI with actions pinned by SHA, LICENSE and CHANGELOG. Removes the no-op copy_assets hook and its command.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
donmanueldev
marked this pull request as ready for review
November 13, 2026 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Lanza la versión 1.1 del paquete de ajustes para NativePHP: almacenamiento con driver intercambiable, getters tipados, un fake para tests, un cliente JS más robusto con tipos TypeScript y el lector del formato v2 en Swift y Kotlin.
Cambios
auto/ native / file / array). En dispositivo siempre se usa native. El fallback a archivo solo aplica en local y testing.Settings::fake()para aserciones en tests, con un store en memoria.getEnum. Si el tipo almacenado no coincide, se devuelve el valor por defecto y se registra solo la clave.all()tolerante conSettingsCorruptedy nuevoallWithReport().__proto__,constructoryprototypese rechazan.SettingsBridgeErrorysettings.d.ts.copy_assetsy de su comando.Cambios de comportamiento
Detalle completo en
CHANGELOG.md.setyforgetahora resuelvenundefined.__proto__,constructoryprototypese rechazan.all()ya no lanza una excepción por entradas corruptas; las omite yallWithReport()informa de ellas.Validación
vendor/bin/pest— 84 tests en verde (312 aserciones) en el paquetenode --test resources/js/settings.test.mjs— 17 tests en verdePendiente antes de marcar como listo
Riesgo y rollback
Revisiones
reviewerysecurity-reviewerejecutados, sin hallazgos bloqueantes; todos los hallazgos corregidos.Publicado sin verificación en dispositivo por decisión del autor; Kotlin pendiente de compilar en un build real.