Skip to content

add further type hints. - #37

Merged
dieJaegerIn merged 2 commits into
mainfrom
improve_typing
Jun 8, 2026
Merged

add further type hints.#37
dieJaegerIn merged 2 commits into
mainfrom
improve_typing

Conversation

@braniii

@braniii braniii commented Jun 8, 2026

Copy link
Copy Markdown
Member

Fixes comment 2 from openjournals/joss-reviews#10244 (comment)

@dieJaegerIn I've added the missing type hints. Feel free to merge if it looks good to you.

@braniii
braniii requested a review from dieJaegerIn June 8, 2026 07:43
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.37%. Comparing base (ca7fa02) to head (010d316).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/dcTMD/io.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   89.29%   89.37%   +0.08%     
==========================================
  Files          11       11              
  Lines         607      612       +5     
==========================================
+ Hits          542      547       +5     
  Misses         65       65              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taenzel taenzel assigned taenzel and unassigned taenzel Jun 8, 2026
@taenzel
taenzel self-requested a review June 8, 2026 07:56
@dieJaegerIn
dieJaegerIn merged commit 43afc82 into main Jun 8, 2026
10 checks passed
@braniii
braniii deleted the improve_typing branch June 8, 2026 11:31
@braniii
braniii requested review from Copilot and dieJaegerIn and removed request for Copilot and dieJaegerIn June 8, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants