Security: replace hardcoded secrets, prevent credential leaks, mitigate script injection - #1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…ential logging, mitigate script injection
- Replace hardcoded RDP_USER/RDP_PASS with ${{ secrets.RDP_USER }}/${{ secrets.RDP_PASS }}
- Remove password from Write-Host log output in Workflow 1
- Replace ts_api_key, ts_authkey, ts_tailnet workflow inputs with ${{ secrets.* }} references
- Route all workflow inputs through env: blocks to prevent script injection
- Remove Administrators group membership for RDP user (keep Remote Desktop Users only)
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security audit found hardcoded RDP credentials, secrets passed as plaintext workflow inputs, password logged to CI output, and script injection vectors in all three workflow files. This PR fixes all of them:
Critical
RDP_USER: Bullettemporary/RDP_PASS: Bullet@12345→${{ secrets.RDP_USER }}/${{ secrets.RDP_PASS }}(Workflow 1 & 2)Write-Host "RDP ready: $u / $p ..."→ password removed from log outputHigh
ts_api_key,ts_authkey,ts_tailnetremoved fromworkflow_dispatchinputs; now read directly from${{ secrets.TS_API_KEY }},${{ secrets.TS_AUTHKEY }},${{ secrets.TS_TAILNET }}Medium
${{ inputs.* }}expressions inrun:blocks replaced withenv:indirection (INPUT_*→$env:INPUT_*) to prevent PowerShell injectionAdministratorsgroup; onlyRemote Desktop Usersmembership retainedRequired setup after merge
Add these GitHub repository secrets:
RDP_USER,RDP_PASS,TS_API_KEY,TS_AUTHKEY,TS_TAILNETLink to Devin session: https://app.devin.ai/sessions/d6a24e2eb8454338a4750bb0d6e0e0b1
Requested by: @mohammad1390555