Add Ghost-issued revocable agent credentials, Settings UI, and Claude MCP plugin #372
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { auth } from "@/auth"; | ||
| import { prisma } from "@/lib/db"; | ||
|
|
||
| export async function DELETE( | ||
| _req: Request, | ||
| context: { params: Promise<{ id: string }> }, | ||
| ) { | ||
| const session = await auth(); | ||
| if (!session?.user.id || !session.user.orgId) { | ||
| return Response.json({ error: "unauthorized" }, { status: 401 }); | ||
| } | ||
| const { id } = await context.params; | ||
| const result = await prisma.agentCredential.updateMany({ | ||
| where: { | ||
| id, | ||
| orgId: session.user.orgId, | ||
| userId: session.user.id, | ||
| revokedAt: null, | ||
| }, | ||
| data: { revokedAt: new Date() }, | ||
| }); | ||
| if (!result.count) | ||
| return Response.json({ error: "credential not found" }, { status: 404 }); | ||
| return Response.json({ revoked: true }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { auth } from "@/auth"; | ||
| import { createAgentToken } from "@ghost/core/agent-credentials"; | ||
| import { prisma } from "@/lib/db"; | ||
|
|
||
| export async function GET() { | ||
| const session = await auth(); | ||
| if (!session?.user.id || !session.user.orgId) { | ||
| return Response.json({ error: "unauthorized" }, { status: 401 }); | ||
| } | ||
| const credentials = await prisma.agentCredential.findMany({ | ||
| where: { | ||
| orgId: session.user.orgId, | ||
| userId: session.user.id, | ||
| revokedAt: null, | ||
| }, | ||
| select: { | ||
| id: true, | ||
| name: true, | ||
| tokenHint: true, | ||
| createdAt: true, | ||
| lastUsedAt: true, | ||
| expiresAt: true, | ||
| }, | ||
| orderBy: { createdAt: "desc" }, | ||
| }); | ||
| return Response.json({ credentials }); | ||
| } | ||
|
|
||
| export async function POST(req: Request) { | ||
| const session = await auth(); | ||
| if (!session?.user.id || !session.user.orgId) { | ||
| return Response.json({ error: "unauthorized" }, { status: 401 }); | ||
| } | ||
| const body = (await req.json().catch(() => null)) as { | ||
| name?: unknown; | ||
| } | null; | ||
| const name = typeof body?.name === "string" ? body.name.trim() : ""; | ||
| if (!name || name.length > 80) { | ||
| return Response.json( | ||
| { error: "name must be between 1 and 80 characters" }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
| const generated = createAgentToken(); | ||
| const credential = await prisma.agentCredential.create({ | ||
| data: { | ||
| orgId: session.user.orgId, | ||
| userId: session.user.id, | ||
| name, | ||
| tokenHash: generated.tokenHash, | ||
| tokenHint: generated.tokenHint, | ||
| }, | ||
| select: { id: true, name: true, tokenHint: true, createdAt: true }, | ||
| }); | ||
| return Response.json({ credential, token: generated.token }, { status: 201 }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| "use client"; | ||
|
|
||
| import { useEffect, useState } from "react"; | ||
| import { Button } from "@/components/ui/button"; | ||
| import { Card, CardBody, CardHeader, CardTitle } from "@/components/ui/card"; | ||
|
|
||
| type Credential = { | ||
| id: string; | ||
| name: string; | ||
| tokenHint: string; | ||
| createdAt: string; | ||
| lastUsedAt: string | null; | ||
| }; | ||
|
|
||
| export function AgentCredentials() { | ||
| const [credentials, setCredentials] = useState<Credential[]>([]); | ||
| const [name, setName] = useState("Claude Code"); | ||
| const [token, setToken] = useState<string | null>(null); | ||
| const [error, setError] = useState<string | null>(null); | ||
|
|
||
| async function refresh() { | ||
| const res = await fetch("/api/settings/agent-credentials"); | ||
| const data = (await res.json()) as { | ||
| credentials?: Credential[]; | ||
| error?: string; | ||
| }; | ||
| if (!res.ok) throw new Error(data.error || "Could not load credentials"); | ||
| setCredentials(data.credentials ?? []); | ||
| } | ||
|
|
||
| useEffect(() => { | ||
| refresh().catch((err) => | ||
| setError(err instanceof Error ? err.message : "Could not load"), | ||
| ); | ||
| }, []); | ||
|
|
||
| async function createCredential() { | ||
| setError(null); | ||
| const res = await fetch("/api/settings/agent-credentials", { | ||
| method: "POST", | ||
| headers: { "content-type": "application/json" }, | ||
| body: JSON.stringify({ name }), | ||
| }); | ||
| const data = (await res.json()) as { token?: string; error?: string }; | ||
| if (!res.ok || !data.token) { | ||
| setError(data.error || "Could not create credential"); | ||
| return; | ||
| } | ||
| setToken(data.token); | ||
| await refresh(); | ||
| } | ||
|
|
||
| async function revoke(id: string) { | ||
| setError(null); | ||
| const res = await fetch(`/api/settings/agent-credentials/${id}`, { | ||
| method: "DELETE", | ||
| }); | ||
| if (!res.ok) { | ||
| const data = (await res.json()) as { error?: string }; | ||
| setError(data.error || "Could not revoke credential"); | ||
| return; | ||
| } | ||
| await refresh(); | ||
| } | ||
|
|
||
| return ( | ||
| <Card> | ||
| <CardHeader> | ||
| <CardTitle>Claude Code and agent access</CardTitle> | ||
| </CardHeader> | ||
| <CardBody className="space-y-4 text-sm"> | ||
| <p className="text-[var(--color-muted)]"> | ||
| Create a revocable Ghost credential for the Claude Code plugin or | ||
| another MCP client. Agents can propose runs, but approval remains in | ||
| Ghost. | ||
| </p> | ||
| <div className="flex gap-2"> | ||
| <input | ||
| aria-label="Credential name" | ||
| className="min-w-0 flex-1 rounded-md border border-[var(--color-border)] bg-transparent px-3 py-2" | ||
| maxLength={80} | ||
| onChange={(event) => setName(event.target.value)} | ||
| value={name} | ||
| /> | ||
| <Button disabled={!name.trim()} onClick={createCredential}> | ||
| Create credential | ||
| </Button> | ||
|
Comment on lines
+85
to
+87
There was a problem hiding this comment.
On a slow connection, double-clicking this still-enabled button sends concurrent POST requests and creates multiple valid credentials. Because each completion overwrites the single Useful? React with 👍 / 👎. |
||
| </div> | ||
| {token && ( | ||
| <div className="rounded-md border border-amber-500/40 bg-amber-500/10 p-3"> | ||
| <p className="font-medium"> | ||
| Copy this credential now. Ghost will not show it again. | ||
| </p> | ||
| <code className="mt-2 block break-all select-all text-xs"> | ||
| {token} | ||
| </code> | ||
| </div> | ||
| )} | ||
| {error && <p className="text-red-500">{error}</p>} | ||
| <div className="space-y-2"> | ||
| {credentials.map((credential) => ( | ||
| <div | ||
| className="flex items-center justify-between gap-3 rounded-md border border-[var(--color-border)] p-3" | ||
| key={credential.id} | ||
| > | ||
| <div> | ||
| <p className="font-medium">{credential.name}</p> | ||
| <p className="font-mono text-xs text-[var(--color-muted)]"> | ||
| {credential.tokenHint} | ||
| </p> | ||
| </div> | ||
| <Button variant="secondary" onClick={() => revoke(credential.id)}> | ||
| Revoke | ||
| </Button> | ||
| </div> | ||
| ))} | ||
| {!credentials.length && ( | ||
| <p className="text-[var(--color-muted)]"> | ||
| No active agent credentials. | ||
| </p> | ||
| )} | ||
| </div> | ||
| </CardBody> | ||
| </Card> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user creates or revokes an agent credential, these routes only mutate
AgentCredentialand never append anAuditEvent; consequently, credential issuance and revocation are absent from the hash-chained organizational audit trail, making security investigations unable to verify these sensitive lifecycle actions. Record both POST and DELETE operations in the audit chain, ideally atomically with their credential mutations.AGENTS.md reference: AGENTS.md:L101-L105
Useful? React with 👍 / 👎.