fix: enable environments#421
Closed
joshuaellis wants to merge 1 commit into
Closed
Conversation
joshuaellis
force-pushed
the
fix/enable-environments
branch
from
fac4780 to
0c16953
Compare
gioboa
reviewed
Mar 3, 2026
gioboa
left a comment
gioboa
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @joshuaellis
is this PR still valid?
Contributor
Author
Not sure, i'lll need to test the new version of the lib and get back to you on that. |
Collaborator
|
I see, so let's close this one, there are a lot of conflicts too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves build-mode resolution of shared dependencies and remote modules from global config.resolve.alias entries to per-environment resolveId hooks. Previously, aliases registered in the config hook leaked into all Vite environments. In a multi-environment build, even the client environment would route shared deps like
defuthrough__loadShare__proxies. The fix keeps aliases for dev mode (where resolveId can't interfere with Vite pre-bundling) but replaces them in build mode with enforce: 'pre' resolveId plugins that return syntheticNamedExports directly, making them compatible with applyToEnvironment scoping.Related PRs