feat: sync MF observability to OpenRuntime#4813
Conversation
🦋 Changeset detectedLatest commit: 3a71953 The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0236c49ce6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "dependencies": { | ||
| "@module-federation/sdk": "workspace:*" | ||
| "@module-federation/sdk": "workspace:*", | ||
| "@openruntime/core": "link:/Users/bytedance/ai/openruntime/packages/core" |
There was a problem hiding this comment.
Replace the absolute local OpenRuntime dependency
This new dependency points at /Users/bytedance/..., so a clean checkout or CI runner that does not have that developer-local path cannot satisfy pnpm install --frozen-lockfile, and a published @module-federation/observability-plugin would also carry an unusable local link. Since the new source imports @openruntime/core, this needs to be a real registry/workspace version rather than an absolute link: path.
Useful? React with 👍 / 👎.
Summary
Verification
pnpm exec prettier --check packages/observability-plugin apps/runtime-demo/3005-runtime-host/cypress/e2e/app.cy.ts apps/runtime-demo/README.mdpnpm --filter @module-federation/observability-plugin run buildpnpm --filter @module-federation/observability-plugin run testpnpm run ci:local --only=e2e-runtime