ci: fail the pytest job when an integration cannot be imported - #259
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #258, which added
REQUIRE_INTEGRATIONSand set it only in the floors job. Thepytestjob also installs every integration (just installrunsuv sync --all-extras, and the dev group has litestar andfaststream[nats]). That means a failed import there would also skip a whole integration suite and the job would stay green. This matters most on the daily scheduled run: it resolves the newest releases, so it is where a new faststream, pydantic or litestar release that breaks the import would show up first.Changes
pytestjob setsREQUIRE_INTEGRATIONS=1on its test step, the same as the floors job.Coverage is unaffected:
import_or_skipis a single expression, so the line is covered either way.Checklist
ruff): no Python changedmypyandpyrefly): no Python changedfaststream<0.6.0,faststream>=0.6.0) replayed locally on 3.12 with the variable set: 458 passed, 0 skipped, coverage 100%uv build) if packaging or build config changed: not applicable