build: move the docs tooling out of the dev group (TL3) - #254
Merged
Merged
Conversation
mkdocs and mkdocs-llmstxt were declared twice: in the dev group and in docs/requirements.txt, which is where the docs recipe already reads them from. TL3 reserves the dev group for test dependencies, and every other repo in the org runs mkdocs through uvx rather than installing it into the project env. Dropping them restores floors (3.14), which #253 had to leave out: watchdog ships no cp314 wheel, so under --no-build the resolver climbed to mkdocs 2.0.dev and pulled an httpx 1.0 prerelease the suite cannot import.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #253, which had to drop
floors (3.14). This removes the cause and restores it.The duplication
mkdocsandmkdocs-llmstxtwere declared in two places:docs/requirements.txtis where thedocsrecipe already read them from, so the dev entries were redundant. TL3 reserves thedevgroup for test dependencies, and nothing intests/or CI touches mkdocs.What it cost
floors (3.14).watchdogships no cp314 wheel, so under--no-buildthe resolver could not usemkdocs 1.6.1and climbed tomkdocs 2.0.dev, which requireshttpx>=1.0.dev5:Unconstrained, that resolved
httpx 1.0.dev6and the suite failed collection onhttpx.BaseTransport, removed in the 1.0 line. #253 dropped the entry under CI6's carve-out for a matrix entry no upstream wheel covers. With mkdocs out of the resolution, the carve-out is not needed:httpxstays at 0.28.1 and the leg passes.Also brings the recipe into line
This was the only repo installing docs tooling into the project environment. The other 23 run it through
uvx.Verified
The exact floors commands on every matrix entry, 3.14 included:
uvx --with-requirements docs/requirements.txt mkdocs build --strictbuilds the site.just lint-ciclean. Normal resolution: 463 passed.mkdocsno longer appears inuv.lockat all.