ci: dogfood with conventional-commits and document release conventions - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small maintenance changes.
Dogfood with
conventional-commits.semvertag.ymlran thebranch-prefixstrategy, which needs a merge commit at the head ofmain. This repo squash-merges, so every run reportedno_merge_commitand never exercised a bump path (e.g. the run ond333e65). The squash titles already follow Conventional Commits; running the strategy over the last 25 commits onmaingivesfeat:→ minor,fix(deps):→ patch, anddocs:/ci:/test:/refactor:/chore:→ none, as expected. A local dry run of this branch against the repo withconventional-commitsreportsalready_tagged 0.9.0for the current head. The now-unusedSEMVERTAG_BRANCH_PREFIX__MINORoverride is dropped, and the header comment says the job computes the head commit's bump: per ADR-0006 it judges one commit, not what has accumulated since the last release.Release conventions in
AGENTS.md. The existing "Cutting a release" section gains what cutting 0.9.0 depended on but no file recorded:semvertag X.Y.Z(the command now says so);feat:or any behaviour change, patch otherwise;## Upgradingsection viagh release edit.Noticed, not changed here: under
conventional-commits, a commit with a valid but non-bumping type (ci:,docs:) reports statusno_conforming_commitwith the reason "No conforming Conventional Commits type found in commit message." This PR's own merge will show that. The status token is frozen wire contract, but the reason text could distinguish "conforming, no bump" from "not conforming".Verified with
just lint-ciandjust docs-build; the workflow YAML parses.