feat: say how many tags were skipped when no_tags fires on a tagged repo - #95
Merged
Merged
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94.
When the forge lists tags but none is SemVer-form, the
no_tagsreason now says so instead of reading as if the repo were tagless:With no tags at all the message is unchanged. The Rich terminal message follows the same pattern.
Decisions (from the triage grilling on #94):
JsonOutput.emitwritesreasonunredacted. Quoting them would need per-field redaction and would undercut the audit pinned in test: pin RunResult's fields so a new one forces a redaction audit #92. A number keepsreasonsemvertag-controlled.no_tags, exit stays 0. Failing CI on upgrade for repos whose only tags are floating majors (v1) or PEP 440 would be worse than the silent green run. The status tokens are a frozen contract.NoTagsoutcome (skipped_tag_count, required, so every producer states it), not onRunResult. Wire fields andschema_versionare unchanged.V1.2.0,release-1.2.0,0.9.0rc1, floatingv1). No ADR, no glossary change.The seed advice is now a constant in both
_outcome.pyand_output.py; ADR-0002 keeps the wire and terminal renderings split, and the existing "edit both" comment covers it.Tests: the use case with a stub provider reports the count (0 and 3);
to_run_resultandRichOutput.emitrender both wordings and the singular.Verified with
just lint-ci,just test-ci(499 passed, 100% coverage),just adr-checkandjust docs-build.