Skip to content

fix(errors): drop skip_creator_parsing advice for parameterized generic params #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Oct 3, 2026
Merged

fix(errors): drop skip_creator_parsing advice for parameterized generic params #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modern_di/providers/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ def __init__( # noqa: PLR0913
parameter_name=param_name,
reason=(
f"parameterized generic annotation {item.raw_annotation!r} cannot be resolved by type; "
f"pass the value via the kwargs parameter, give the parameter a default, "
f"or use skip_creator_parsing=True"
"pass the value via the kwargs parameter or give the parameter a default"
),
)
self._parsed_kwargs = parsed.params
Expand Down
3 changes: 2 additions & 1 deletion tests/test_types_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,9 @@ def _generic_param_creator(x: list[_GenericDep]) -> str:

def test_parameterized_generic_param_without_default_raises_at_declaration() -> None:
assert _generic_param_creator([]) == "[]"
with pytest.raises(exceptions.UnsupportedCreatorParameterError, match=r"list\[.*_GenericDep\]"):
with pytest.raises(exceptions.UnsupportedCreatorParameterError, match=r"list\[.*_GenericDep\]") as exc_info:
providers.Factory(creator=_generic_param_creator)
assert "skip_creator_parsing" not in str(exc_info.value)


def test_parameterized_generic_param_supplied_via_kwargs_is_allowed() -> None:
Expand Down
Loading