Skip to content

fix(errors): drop skip_creator_parsing advice for positional-only params #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Oct 3, 2026
Merged

fix(errors): drop skip_creator_parsing advice for positional-only params #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions modern_di/types_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,7 @@ def _parse_parameter(
raise exceptions.UnsupportedCreatorParameterError(
creator=creator,
parameter_name=param_name,
reason=(
"positional-only parameters cannot be passed by keyword; "
"give the parameter a default or use skip_creator_parsing=True"
),
reason="positional-only parameters cannot be passed by keyword; give the parameter a default",
)

default = UNSET
Expand Down
1 change: 1 addition & 0 deletions tests/test_types_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ def test_positional_only_param_raises_at_declaration() -> None:
providers.Factory(creator=_pos_only_creator)
# kwargs cannot help: the creator is always invoked creator(**kwargs)
assert "kwargs" not in str(exc_info.value)
assert "skip_creator_parsing" not in str(exc_info.value)


def _pos_only_with_default(x: int = 0, /, y: int = 1) -> int:
Expand Down
Loading