docs(agents): run just install before just lint - #546
Merged
Merged
Conversation
uv.lock is gitignored and CI upgrades the lock before syncing, so a plain uv sync leaves ruff and ty behind what CI runs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 435a719 | Previous: 2fa9349 | Ratio |
|---|---|---|---|
benchmarks/test_guard_by_type.py::test_g16_resolve_by_type |
3266153.029264524 iter/sec (stddev: 2.726996405438711e-8) |
6896321.529588829 iter/sec (stddev: 1.656394651362622e-8) |
2.11 |
benchmarks/test_guard_by_type.py::test_g17_resolve_by_type_large_registry |
3444263.7698468138 iter/sec (stddev: 2.1516681329844438e-8) |
6723886.492428997 iter/sec (stddev: 4.553769677747909e-9) |
1.95 |
benchmarks/test_guard_cold.py::test_g8_cold_first_resolve |
14880.091149748172 iter/sec (stddev: 0.00005422169044320411) |
27737.93260434483 iter/sec (stddev: 0.0002769165059218651) |
1.86 |
benchmarks/test_guard_cold.py::test_g8b_cold_first_resolve_cached |
11694.73600363711 iter/sec (stddev: 0.0001689784162825639) |
28309.530850614217 iter/sec (stddev: 0.000026160479444661588) |
2.42 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[1] |
369.4217909871339 iter/sec (stddev: 0.00006827305310229136) |
919.005067710707 iter/sec (stddev: 0.00002110680578158713) |
2.49 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[2] |
362.36068079687163 iter/sec (stddev: 0.00005056003200387255) |
866.1064567994413 iter/sec (stddev: 0.000026437862156853062) |
2.39 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[4] |
336.13430406588907 iter/sec (stddev: 0.00009514135676739539) |
757.1283783045287 iter/sec (stddev: 0.00006926914874381573) |
2.25 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[1] |
1648.5590542904324 iter/sec (stddev: 0.0001750054469198464) |
3319.8385584483176 iter/sec (stddev: 0.0001047978210340891) |
2.01 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[2] |
1311.5190411357764 iter/sec (stddev: 0.0001983885716327905) |
2645.0928193804793 iter/sec (stddev: 0.0001251134082363881) |
2.02 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[4] |
953.1235112411159 iter/sec (stddev: 0.00020913897764949003) |
1395.6979077514745 iter/sec (stddev: 0.0018265189006618015) |
1.46 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[1] |
1604.9722038879854 iter/sec (stddev: 0.0002081883833609017) |
3312.7647451113257 iter/sec (stddev: 0.00012831484056759503) |
2.06 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[2] |
1063.7912342322663 iter/sec (stddev: 0.0011029509476823832) |
2398.2347074046947 iter/sec (stddev: 0.00012340780911521343) |
2.25 |
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[4] |
786.2993420366987 iter/sec (stddev: 0.0002027396908227558) |
1522.3831812586595 iter/sec (stddev: 0.00016676248654669626) |
1.94 |
benchmarks/test_guard_lifecycle.py::test_g6_build_child_container |
799839.2962875008 iter/sec (stddev: 3.537260728054921e-8) |
1659387.9687512352 iter/sec (stddev: 2.797734564860336e-8) |
2.07 |
benchmarks/test_guard_lifecycle.py::test_g6b_build_child_container_auto_scope |
721329.7569806176 iter/sec (stddev: 3.4841765759607424e-8) |
1437014.2981452 iter/sec (stddev: 4.1462969455976323e-8) |
1.99 |
benchmarks/test_guard_lifecycle.py::test_g7_request_lifecycle_batch |
2194.8887777153304 iter/sec (stddev: 0.00008116411148140905) |
5095.098694066629 iter/sec (stddev: 0.000010128823996295889) |
2.32 |
benchmarks/test_guard_lifecycle.py::test_g7c_event_loop_floor_control |
58045.17261828067 iter/sec (stddev: 0.000001794556669776985) |
116996.98751354073 iter/sec (stddev: 6.508873667337742e-7) |
2.02 |
benchmarks/test_guard_lifecycle.py::test_g13_teardown_at_scale |
44106.36793498056 iter/sec (stddev: 0.000002105808886533531) |
91702.05398631941 iter/sec (stddev: 0.0000011927020175642189) |
2.08 |
benchmarks/test_guard_lifecycle.py::test_g13b_teardown_at_scale_async_no_finalizers |
570.193432895315 iter/sec (stddev: 0.000058544056343979904) |
1199.2794480231455 iter/sec (stddev: 0.00002473683808544772) |
2.10 |
benchmarks/test_guard_resolve.py::test_g1_transient_resolve |
2133743.8087462652 iter/sec (stddev: 3.557205528361526e-8) |
4142386.671289167 iter/sec (stddev: 2.450902839898593e-8) |
1.94 |
benchmarks/test_guard_resolve.py::test_g2_cached_resolve |
3160688.419430067 iter/sec (stddev: 3.1406519393286364e-8) |
6984206.892358632 iter/sec (stddev: 3.999959927059171e-9) |
2.21 |
benchmarks/test_guard_resolve.py::test_g3_deep_chain |
709234.9734123345 iter/sec (stddev: 4.451061035996343e-8) |
1441971.9312253916 iter/sec (stddev: 3.293579234637171e-8) |
2.03 |
benchmarks/test_guard_resolve.py::test_g4_wide_resolve |
456562.9126686667 iter/sec (stddev: 4.2747090251470565e-7) |
866492.9723615798 iter/sec (stddev: 2.882483470000903e-7) |
1.90 |
benchmarks/test_guard_resolve.py::test_g5_cross_scope |
1888004.2487640667 iter/sec (stddev: 3.010294379588629e-8) |
3842119.620542437 iter/sec (stddev: 2.034228407139395e-8) |
2.04 |
benchmarks/test_guard_resolve.py::test_g9_context_resolve |
1082576.2065980479 iter/sec (stddev: 1.5404892587644076e-7) |
2017060.6011464521 iter/sec (stddev: 1.449309837061137e-7) |
1.86 |
benchmarks/test_guard_resolve.py::test_g12_override_active_resolve |
721767.0097848543 iter/sec (stddev: 6.527273210025417e-8) |
1470802.474999698 iter/sec (stddev: 1.91473454451071e-8) |
2.04 |
benchmarks/test_guard_resolve.py::test_g18_alias_hop |
2126909.861367046 iter/sec (stddev: 1.7288873198872215e-8) |
5088685.871771255 iter/sec (stddev: 4.309233123887382e-9) |
2.39 |
benchmarks/test_guard_validate.py::test_g10_validate_deep_chain |
23486.67228422138 iter/sec (stddev: 0.000021224968166186987) |
45784.12805048304 iter/sec (stddev: 0.000017301051291933258) |
1.95 |
benchmarks/test_guard_validate.py::test_g11_validate_wide |
14187.955556037217 iter/sec (stddev: 0.000024670321478872605) |
26997.329478205094 iter/sec (stddev: 0.00001689074144621725) |
1.90 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one paragraph to the Commands section of
AGENTS.md.uv.lockis gitignored and CI'sjust installrunsuv lock --upgradebefore it syncs, so CI always lints with the newestruffandty. A checkout that only ranuv synckeeps its old resolution. Today that gap let a covariance error in #545 through a localty0.0.74 pass and fail on CI's 0.0.84. The habit is:just installbeforejust lint, in every checkout and worktree.