Conversation
Widen the requirement to modern-di>=3,<5. ADR 0002 now describes the 4.0 behaviour on a closed container, and the fetch_task_name test helper drops its unused None default.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs modern-python/modern-di#579.
Summary
modern-di>=3,<5.docs/adr/0002-only-worker-lifecycle-is-wired.md: the last sentence citedContainerClosedWarning, which 4.0 removes. It now says that from 4.0 a resolve from a closed container raisesContainerClosedError, so the unconditionalcontainer.open()on worker startup is what keeps the second worker cycle working.tests/dependencies.py:fetch_task_nametookmessage: TaskiqMessage | None = None. Tests only resolve it inside a task, wheretaskiq_message_providerhas a value, and in 4.0 a registeredContextProviderwith no value raises regardless of the creator default. The parameter is now required.Verification
This PR stays a draft until modern-di 4.0.0 is on PyPI.