chore: drop the unused typing-extensions lint dependency - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lintgroup'styping-extensionswas inherited from modern-di core's template. Core added it to its own lint dependencies in its first commit, when its code importedtyping_extensions. Nothing in this repo imports it, andtydoes not report unresolved imports inside installed packages, so it was never needed.typasses without it even against modern-di 3.5.0, whose code still had aTYPE_CHECKINGimport oftyping_extensions.Changes
typing-extensionsfrom thelintdependency group..github/scripts/report-scheduled-failure.sh.Verification
On 3.11:
just lint-ciandjust test-cipass, with 100% coverage. Other dependencies still installtyping-extensionshere, so this run alone can't prove it unneeded. That proof comes from modern-di-flask and modern-di-pytest, where nothing else installs it,typing_extensionscan't be imported, andtyand the tests still pass.Release
None needed. Only the lint group and a CI script change, so nothing users install is affected.