Repository navigation
docs: fix WebSocketEndpoint example scope error - #43
Merged
Merged
Conversation
- Echo.on_receive injected a REQUEST-scoped provider from the SESSION child - drop em dash - footer wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
WebSocketEndpointexample, which raisedScopeNotInitializedError.Changes
Echo.on_receiveexample injectedDependencies.user_service, aREQUEST-scoped provider. A WebSocket connection gets aSESSION-scoped child (starlette_websocket_provider, modern_di_starlette/main.py:18), so resolution failed with "Provider of scope REQUEST cannot be resolved in container of scope SESSION". It now injects theAPP-scopedDependencies.settings, and the scopes paragraph says WebSocket handlers can injectAPPandSESSIONdependencies but notREQUESTones.setup_dinote.Verified with a scratch app (TestClient): the old example fails with the error above; the new one echoes over the WebSocket and the
HTTPEndpointroute still returns 200.Checklist
ruff)ty)uv build) if packaging or build config changeddescription, profile blurb) if this touches packaging