docs: fix README override example and wording - #61
Merged
Merged
Conversation
- Apply the override in a fixture so generated fixtures resolve against it - Replace version note on validate() with current behavior - Remove em dashes; fix shared footer wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README fixes from a docs review.
The Overrides example applied
di_container.override(...)inside the test body, butuser_serviceis a fixture that already resolved during setup (modern_di_pytest/factory.py,_fixturecallscontainer.resolve_dependencyeagerly). The assertion ran against the real repo. Reproduced as a pytest run: the old example fails withassert ['real'] == []; the new one passes.Changes
di_containerin the test module and apply the override there (with di_container.override(...)), so generated fixtures resolve against itmodern-di>=3,<4)descriptionuntouched)Checklist
ruff)ty)uv build) if packaging or build config changeddescription, profile blurb) if this touches packaging