docs: fix FromDI facts in README - #62
Merged
Merged
Conversation
- setup_di does not build child containers; FromDI builds one on demand - FromDI parameter is named dependency - add scopes to context-provider rows, drop em dash - footer wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix README statements that do not match the code.
Changes
setup_di"builds a per-connection child container automatically".setup_di(modern_di_fastapi/main.py:54-58) only stores the container, registers the context providers and composes the lifespan. The child is built on demand byDepends(build_di_container)insideFromDI(main.py:74-77), so only routes that useFromDIget one.FromDI(provider, ...)->FromDI(dependency, ...), matching the signature at main.py:80.build_di_containerrow; added the scope to thefastapi_request_provider(REQUEST) andfastapi_websocket_provider(SESSION) rows (main.py:14-15), as the aiohttp and starlette READMEs do.Checklist
ruff)ty)uv build) if packaging or build config changeddescription, profile blurb) if this touches packaging