Skip to content

docs: list all worker signals and inject TypeError in README - #35

Merged
lesnik512 merged 1 commit into
mainfrom
docs/fix-facts
Oct 3, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
docs/fix-facts

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Summary

The README said setup_di only uses worker_process_init/worker_process_shutdown, and the inject row omitted its decoration-time TypeError.

Evidence:

  • modern_di_celery/main.py:39-40 also connects worker_init/worker_shutdown, the only signals the threads/gevent/eventlet pools send (comment at :29-36).
  • modern_di_celery/main.py:68-75: inject raises TypeError when the task declares *args/**kwargs.

Changes

  • Usage paragraph, eager-mode note, and setup_di row mention both signal pairs.
  • inject row documents the TypeError.
  • Remove the dash in the eager-mode note.
  • Footer: "with IoC container" -> "with an IoC container", and the org-profile line no longer uses a dash.

Checklist

  • Lint and format pass (ruff)
  • Type check passes (ty)
  • Tests pass and new behavior is covered
  • Build succeeds (uv build) if packaging or build config changed
  • Repo metadata stays consistent across the three surfaces (GitHub description, pyproject description, profile blurb) if this touches packaging

Docs-only change. just lint-ci and just test pass; no mkdocs.yml in this repo.

- setup_di also connects worker_init/worker_shutdown (threads/gevent/eventlet pools)
- inject raises TypeError at decoration for *args/**kwargs
- Drop dash in eager-mode note
- Footer wording fix
@lesnik512
lesnik512 merged commit 62f3f59 into main Oct 3, 2026
14 checks passed
@lesnik512
lesnik512 deleted the docs/fix-facts branch October 3, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant