docs: list all worker signals and inject TypeError in README - #35
Merged
Merged
Conversation
- setup_di also connects worker_init/worker_shutdown (threads/gevent/eventlet pools) - inject raises TypeError at decoration for *args/**kwargs - Drop dash in eager-mode note - Footer wording fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README said setup_di only uses
worker_process_init/worker_process_shutdown, and theinjectrow omitted its decoration-time TypeError.Evidence:
modern_di_celery/main.py:39-40also connectsworker_init/worker_shutdown, the only signals the threads/gevent/eventlet pools send (comment at :29-36).modern_di_celery/main.py:68-75:injectraisesTypeErrorwhen the task declares*args/**kwargs.Changes
setup_dirow mention both signal pairs.injectrow documents theTypeError.Checklist
ruff)ty)uv build) if packaging or build config changeddescription, profile blurb) if this touches packagingDocs-only change.
just lint-ciandjust testpass; no mkdocs.yml in this repo.