Skip to content

test: bound the HTTP-date Retry-After delay by the call's own clock window #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Oct 4, 2026
Merged

test: bound the HTTP-date Retry-After delay by the call's own clock window #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,8 @@ async def test_retry_after_seconds_overrides_backoff() -> None:

async def test_retry_after_http_date_overrides_backoff() -> None:
sleeper = _SleepRecorder()
future = datetime.datetime.now(datetime.UTC) + datetime.timedelta(seconds=3)
before = datetime.datetime.now(datetime.UTC)
future = before.replace(microsecond=0) + datetime.timedelta(seconds=3)
http_date = email.utils.format_datetime(future, usegmt=True)
handler = _ResponseSequenceWithHeaders(
[
Expand All @@ -281,9 +282,10 @@ async def test_retry_after_http_date_overrides_backoff() -> None:
)
client = _client(handler, retry=AsyncRetry(_sleep=sleeper, base_delay=0.01, max_delay=10.0))
response = await client.get("https://example.test/x")
after = datetime.datetime.now(datetime.UTC)
assert response.status_code == HTTPStatus.OK
assert len(sleeper.calls) == 1
assert 2.0 <= sleeper.calls[0] <= 4.0 # noqa: PLR2004 — ~3 seconds, with clock-skew tolerance
assert (future - after).total_seconds() <= sleeper.calls[0] <= (future - before).total_seconds()


async def test_retry_after_exceeding_max_delay_raises_with_note() -> None:
Expand Down
Loading