docs: drop the README note about scoping the rebalance flush to revoked partitions - #97
Merged
Merged
Conversation
…ed partitions aiokafka only implements eager rebalancing, so the revoked set is always the consumer's whole assignment; the optimization was declined in #63.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the README sentence "A future optimization may scope the wait to only the revoked partitions."
#63 proposed that optimization and was closed as
wontfix: aiokafka only implements eager rebalancing, soon_partitions_revokedalways receives the consumer's entire previous assignment, and scoping to "revoked partitions" would wait on the same work as today for a single-subscriber handler. The README should not promise it.