Make concurrent integration test assertions order-independent - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_real_kafka_direct_ack_from_handler_is_refusedandtest_real_kafka_stop_application_from_inner_middleware_does_not_kill_the_apprun withconcurrency_limit=5, so messages 1 and 2 are handled concurrently and can finish in either order. Both tests asserted[1, 2]in completion order, and CI run 37190570935 (floors 3.11) failed withassert [2, 1] == [1, 2].The tests are meant to check which messages got processed, not the order they finished in, so both now compare sorted ids.
I checked the rest of
tests/test_integration.py. The remaining multi-message assertions already usesorted()or only check counts, and the single-message ones can't depend on order.No failing test was written first. The failure is a scheduling race that can't be reproduced on demand.
just lintandjust test(227 passed) pass locally.