Repository navigation
feat!: drop Python 3.10 and use typing.assert_never - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
Python 3.10 reaches end of life on 2026-10-31. This drops it ahead of that date rather than waiting for the trigger recorded in ADR-0002.
Changes
requires-pythonis now>=3.11,<4, and the 3.10 classifier is gone. Ruff takes its target fromrequires-python, so no[tool.ruff] target-versionis added.lintnow runs on 3.11, and"3.10"is dropped from both thepytestandfloorsmatrices. The issue only mentionedpytest.fixer.py: the vendored_assert_neveris replaced withtyping.assert_never. The exhaustivematchkeeps itscase _:arm._assert_never") is deleted, not superseded. Its decision no longer holds, and using the stdlib helper on 3.11+ does not meet the FL4 bar for a record of its own. The ADR tree indocs/agents/domain.mdis updated; it was also missing 0003.The issue cites "ADR-0004", but the record is 0002.
Verification
just lint-ci,just test-ci(100% coverage) andjust adr-checkall pass.Truncatearm temporarily removed,ty checkreportstype-assertion-failureatassert_never(action), so the exhaustiveness guard still works.Release
This is a breaking change because it drops a supported interpreter. Release it as a minor or major version, not a patch.