Skip to content

fix(workers): do not cache screenshot failures - #261

Merged
benvinegar merged 1 commit into
mainfrom
fix/screenshot-error-cache
Aug 18, 2026
Merged

fix(workers): do not cache screenshot failures#261
benvinegar merged 1 commit into
mainfrom
fix/screenshot-error-cache

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • preserve Browser Rendering responses unless they are successful PNGs
  • return Cache-Control: no-store for failed or non-PNG captures
  • cover 429 JSON and 200 text capture responses

Validation

  • node --test test/workerScreenshotCache.test.ts
  • npm run typecheck
  • npm run lint
  • npm run test:worker

This PR description was generated by Pi using gpt-5.6-terra

@benvinegar
benvinegar merged commit 0658840 into main Aug 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant