perf(workers): cache social preview images - #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cache fully pinned social-preview screenshots in Cloudflare's local edge Cache API so repeat unfurls avoid another Browser Rendering invocation.
How
vto the renderer's historicalverlookup, so nonexistent or forged revisions fail before cache accessprivate; only configured public-read boards emitpublicimage responsesnocache, unversioned, malformed, or incompletely pinned requestsx-sideshow-screenshot-cache: hit|missfor verificationThis is the OSS adaptation of the cache approach proven in
sideshow-cloud; it requires no R2 bucket, new binding, or prewarming.Validation
npm test— 476 Node tests and 4 viewer tests passednpm run typechecknpm run lintnpm run format:checknpm run buildnpm run test:workernpm run security:auditThis PR description was generated by Pi using gpt-5.6-sol