test(pty): wait for settled interactive frames - #680
Open
benvinegar wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR hardens PTY tests against startup and partial-paint timing races.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified. The synchronization changes preserve adequate polling budgets, deliberately distinguish startup retries from overlay-close failures, and strengthen assertions without changing production behavior. Important Files Changed
Reviews (1): Last reviewed commit: "test(pty): wait for settled interactive ..." | Re-trigger Greptile |
benvinegar
force-pushed
the
fix/main-ci-pty-races
branch
from
August 6, 2026 15:29
e1f6aeb to
d5dac02
Compare
benvinegar
force-pushed
the
fix/main-ci-pty-races
branch
from
August 6, 2026 15:37
d5dac02 to
c40da15
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Two consecutive
mainruns failed in different PTY tests. One sentTabbefore keyboard subscription, causing thetinbetato open the theme selector. The other accepted a transitional resize frame before the expected row text finished painting. A rerun of unchangedmainpassed, confirming timing races rather than a product regression.After rebasing onto the latest
main, Windows exposed another synchronization issue: a workspace test deleted its temporary checkout while the successful-write reload still had a Git child process using it. The test now waits for the reloaded content, which is the actual completion condition it should assert.Validation
bun run format:checkbun run lintbun run typecheckThis PR description was generated by Pi using OpenAI GPT-5.6