fix: migrate renamed channels in place - #78
Merged
Conversation
Change-Id: I7fb187c56bf95b3c7b83ba5975377be139767f69
heimanba
marked this pull request as ready for review
August 12, 2026 03:27
Change-Id: Ic93af7b21bc96fe91dfcebee00ee0e2db9c56b58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CHANNEL_CREDENTIAL_CONFLICTas credential ownership instead of a stale-name conflict.Why
Qoder allows a DingTalk credential set to belong to only one Channel. The previous create-before-delete plan attempted to create the renamed Channel while the old Channel still owned those credentials, causing
CHANNEL_CREDENTIAL_CONFLICT. Users then had to run apply twice or manually manipulate state.After this change, a safe rename is transparent: users edit
agents.yamland runagents apply; the existing remote Channel is updated in place.Safety
Rename inference is conservative. It requires a unique same-provider, same-type match, using the stored credential fingerprint when available. Ambiguous plans retain the existing create/delete behavior rather than guessing. If the in-place update fails, deletion of the old referenced Identity or Template is skipped.
Validation
git diff --check: passed