fix(infer): share a background event loop across synchronous requests - #10080
Open
taking-lying-flat wants to merge 1 commit into
Open
fix(infer): share a background event loop across synchronous requests#10080taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Interleaving two streams returned by synchronous
infer(..., stream=True)can hang the second consumer: each iterator starts a thread that callsrun_until_complete()on the same cached event loop. Once the first stream is running, the second thread raisesRuntimeError: This event loop is already runningoutside the coroutine's error handler, leaving its result queue empty.Run the engine's shared loop in one daemon thread using the existing utility, serialize lazy initialization, and submit both streaming and non-streaming work with
asyncio.run_coroutine_threadsafe(). Reusing the loop preserves background tasks bound to the engine's first loop.This change only modifies the synchronous bridge in
swift/infer_engine/infer_engine.py.Experiment results
tests.infer.test_infer_engineandtests.infer.test_infer_engine_limitspassed.Regression scripts were kept outside the repository; the PR contains production code only.