fix: support QSA with sequence parallelism - #180
Merged
tastelikefeet merged 3 commits intoSep 5, 2026
Conversation
hjh0119
approved these changes
Sep 1, 2026
tastelikefeet
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For Qwen3.8-Flash-Next, the gathered width is 640 (
(4 + 1) * 128) instead of the 2560-wide hidden state, reducing the new communication volume by 75% compared with gatheringhidden_statesdirectly.Fixes #178.
Validation
Nonebefore projection or communicationpre-commit run --all-filespython3 -m py_compile src/mcore_bridge/model/gpts/qwen4_exp.py src/mcore_bridge/model/modules/qsa_indexer.pyThe validation harness was intentionally not committed; this PR contains production code only.