Skip to content

Fix soxr package environment dependency bug #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WarmCongee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix soxr package environment dependency bug #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ torchaudio>=2.0.2
yamlargparse==1.31.1
torchinfo==1.8.0
tqdm==4.67.0
soxr==0.5.0.post1

@gemini-code-assist gemini-code-assist Bot Dec 9, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning the soxr version is a great step towards ensuring build stability. However, I've noticed that many other packages in this file (e.g., pyyaml, pysptk, pymcd) are not pinned to a specific version. This leaves the project vulnerable to future build failures if any of those packages release breaking changes, similar to the issue this PR is fixing. For reproducible and stable environments, it's a strong best practice to pin all dependencies to specific versions. Consider using a tool like pip-tools to manage and generate a fully pinned requirements.txt.

pyyaml
pysptk
pymcd
Expand Down