fix(sequential-thinking): preserve nextThoughtNeeded in required schema fields - #4695
Open
AbhiPra24 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4651.
In #3533, boolean parameters in
src/sequentialthinking/index.tswere switched to usez.preprocess()to support string booleans from LLMs. However,z.preprocess()wraps the underlying schema into a pipeline acceptingunknown, causing Zod's JSON schema generation (z.toJSONSchema) to omitnextThoughtNeededfrom therequiredproperties list.This caused MCP clients constructing calls based strictly on the declared required tool schema to omit
nextThoughtNeededand receive validation error-32602at runtime.This PR fixes the issue by replacing
z.preprocess()withz.union([z.boolean(), z.string().transform(...)]). This preserves case-insensitive string-to-boolean coercion while correctly emittingnextThoughtNeededin the tool'sinputSchema.requiredarray.Changes
coercedBooleandefinition insrc/sequentialthinking/index.tstoz.union.src/sequentialthinking/__tests__/schema.test.tsverifying input schema generation, required fields, and boolean/string parsing.Verification
npm testandnpm run buildinsrc/sequentialthinking. All 18 tests pass with 100% coverage on schema logic.