fix(filesystem): preserve UTF-8 across head and tail chunks - #4667
Open
Excelius-Wang wants to merge 1 commit into
Open
fix(filesystem): preserve UTF-8 across head and tail chunks#4667Excelius-Wang wants to merge 1 commit into
Excelius-Wang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4666.
Preserve multi-byte UTF-8 characters when
headFile()andtailFile()read across 1024-byte chunk boundaries.StringDecoderfor forward chunk decoding inheadFile().tailFile()and decode only after enough line separators have been collected.Server Details
head_fileandtail_fileMotivation and Context
Decoding every chunk independently replaces split UTF-8 sequences with U+FFFD. This corrupts CJK and other multi-byte text returned by the filesystem server.
How Has This Been Tested?
npm test— 154 tests passednpm run buildheadFile()andtailFile()with界split across a 1024-byte boundaryThe change was tested at the filesystem operation boundary rather than through an LLM client.
Breaking Changes
None.
Types of changes
Checklist