fix(sequentialthinking): restore nextThoughtNeeded in required schema and dynamic version - #4655
Open
AbhiPra24 wants to merge 1 commit into
Open
Conversation
…ic version resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4651 and #4575.
1. Restore
nextThoughtNeededininputSchema.required(Fixes #4651)nextThoughtNeededwas previously wrapped in az.preprocess()-based boolean coercion. Zod'stoJSONSchema(..., { io: "input" })treatsz.preprocess()input asunknown, silently dropping the field from the emittedrequiredarray while runtime validation still requires it, causing-32602 Invalid paramsfor clients constructing calls from the advertised schema.z.preprocess()with a union transformation:nextThoughtNeededinrequired: ["thought", "nextThoughtNeeded", "thoughtNumber", "totalThoughts"].2. Dynamic Server Version (Fixes #4575)
package.jsonrather than a hardcoded"0.2.0".Verification
src/sequentialthinking/__tests__/index.test.ts.npm run buildandnpm testpassed (21/21 tests green).cc @olaservo for review when available. Thank you!