fix(filesystem): support recursive create_directory and prevent move_file overwrites - #4654
Open
AbhiPra24 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4629 and #4628.
1.
create_directoryparent creation (Fixes #4629)create_directoryis called on a path with multiple non-existent parent directories (e.g.<allowed_dir>/a/b/c),validatePath()failed onpath.dirname()throwing"Parent directory does not exist: <allowed_dir>/a/b", preventing recursive directory creation even thoughcreate_directorypasses{ recursive: true }tofs.mkdir.validatePath(), when a path does not exist (ENOENT), walk up ancestor directories until an existing ancestor is found, resolving it viafs.realpathand verifying it stays withinallowedDirectories.2.
move_filenon-overwriting behavior (Fixes #4628)move_filecalledfs.renamedirectly, silently overwriting existing destination files and causing data loss, violating the documented contract ("If the destination exists, the operation will fail").await fs.lstat(validDestPath)to throwDestination already exists: <path>when target is occupied.Verification
src/filesystem/__tests__/lib.test.tsandsrc/filesystem/__tests__/structured-content.test.ts.npm run buildandnpm testinsrc/filesystempassed (157/157 tests green).cc @olaservo for review when available. Thank you!