Make memory graph writes atomic - #4617
Closed
joenermunch wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Memory graph updates are now written to a unique temporary file in the same directory. The completed file is renamed over the target only after the write succeeds. Failed writes remove the temporary file and leave the previous graph intact.
Fixes #4614.
Server Details
Motivation and Context
Direct writes truncate the target before the replacement content is complete. An interrupted write can therefore corrupt the only persisted copy of the graph.
How Has This Been Tested?
npm test --workspace @modelcontextprotocol/server-memory -- --maxWorkers=4(51 tests)npm run build --workspace @modelcontextprotocol/server-memoryBreaking Changes
None.
Types of changes
Checklist
Additional context
The temporary file is created beside the memory file so the rename stays on the same filesystem. Its randomized name also avoids collisions between concurrent processes.