Skip to content

fix(git): stop opting into raise_exceptions=True - #4232

Open
whyujjwal wants to merge 1 commit into
modelcontextprotocol:mainfrom
whyujjwal:fix/git-raise-exceptions-4213
Open

fix(git): stop opting into raise_exceptions=True#4232
whyujjwal wants to merge 1 commit into
modelcontextprotocol:mainfrom
whyujjwal:fix/git-raise-exceptions-4213

Conversation

@whyujjwal

Copy link
Copy Markdown

Summary

  • stop passing raise_exceptions=True when starting the Python git server
  • align git server behavior with sibling Python servers so JSON-RPC validation errors are returned to the client instead of crashing the process
  • add a regression test covering the serve() startup path

Testing

  • uv run pytest tests/test_server.py -q
  • uv run ruff check tests/test_server.py src/mcp_server_git/server.py
  • uv run pyright

Closes #4213

@LuuOW LuuOW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical audit: Verified MCP server implementation for consistency with current SDK patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[git] raise_exceptions=True

2 participants