feat(fetch): implement streaming byte cap to prevent resource exhaustion - #4185
Open
neuralmanacle wants to merge 3 commits into
Open
feat(fetch): implement streaming byte cap to prevent resource exhaustion#4185neuralmanacle wants to merge 3 commits into
neuralmanacle wants to merge 3 commits into
Conversation
- Refactor fetch_url to use streaming for memory-safe downloads - Add MAX_RESPONSE_BYTES safety cap (2MB) to prevent resource exhaustion - Improve error handling for timeouts and network failures - Update and fix tests to support async streaming logic - Add new test cases for size limit enforcement - Consolidate tool configuration into pyproject.toml
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the response-size vulnerabilities outlined in #4116 by implementing a defensive streaming byte cap (2MB limit) inside the Python
fetchserver.Server Details
fetchtools(fetch execution logic)Motivation and Context
Prior to this change, letting an autonomous AI agent loose on arbitrary URLs could allow a single massive file or unconstrained stream to exhaust memory and crash the server runtime. This isolates a critical server-side performance safeguard approved by the maintainers.
Types of changes
Checklist