filesystem: add structured startup validation errors - #4056
Open
Shiyao-Huang wants to merge 1 commit into
Open
Conversation
LuuOW
reviewed
Jun 13, 2026
LuuOW
left a comment
There was a problem hiding this comment.
Technical audit: Verified MCP server implementation for consistency with current SDK patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3512 by adding a machine-readable fatal startup validation error for the filesystem server.
When startup fails because no allowed directory is accessible, the server now emits a stable JSON payload on
stderrwith:type: "startup_validation_error"code: "no_accessible_directories"messagerejectedInputs[]containing:inputcheckedPathsreason(inaccessibleornot_directory)The existing fail-closed behavior remains unchanged, and per-path warning output is preserved.
Files Changed
src/filesystem/index.tssrc/filesystem/__tests__/startup-validation.test.tsValidation
Notes
not_directoryfatal case