Skip to content

fix(sequential-thinking): remove unused dependency - #3792

Open
kt3k wants to merge 2 commits into
modelcontextprotocol:mainfrom
kt3k:remove-unused-dependency-yargs
Open

fix(sequential-thinking): remove unused dependency#3792
kt3k wants to merge 2 commits into
modelcontextprotocol:mainfrom
kt3k:remove-unused-dependency-yargs

Conversation

@kt3k

@kt3k kt3k commented Apr 2, 2026

Copy link
Copy Markdown

Description

sequentialthinking server has unused dependency yargs. This PR removes it.

How Has This Been Tested?

npm test still passes with yargs dependency removed.

Additional context

yargs is relatively a large package https://bundlephobia.com/package/yargs@17.7.2. This change significantly reduces the amount the users need to download.

@cliffhall cliffhall added bug Something isn't working server-sequentialthinking Reference implementation for the Sequential Thinking MCP server - src/sequentialthinking labels Apr 20, 2026
@cliffhall

Copy link
Copy Markdown
Member

@claude review

@claude

claude Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Claude finished @cliffhall's task in 53s —— View job


PR Review: fix(sequential-thinking): remove unused dependency

  • Read changed files
  • Verify yargs is not used anywhere in sequentialthinking source
  • Review package.json changes
  • Post review findings

Summary

This is a clean, well-targeted dependency cleanup. Approving this change is straightforward.

Verification: yargs is genuinely unused

Searched all TypeScript source files in src/sequentialthinking/ (index.ts, lib.ts, __tests__/lib.test.ts, vitest.config.ts) — no references to yargs were found anywhere. The server uses:

  • @modelcontextprotocol/sdk — active use in index.ts
  • chalk — active use in lib.ts for formatting thought output
  • zod — active use in index.ts for schema validation

yargs (and @types/yargs) appear to be a leftover from an earlier version of the server that may have used CLI argument parsing directly. The current server uses stdio transport from the MCP SDK with no direct CLI argument parsing.

package.json changes (src/sequentialthinking/package.json)

The diff removes from dependencies:

- "yargs": "^17.7.2"

And from devDependencies:

- "@types/yargs": "^17"

Both removals are correct. No other dependencies were touched.

package-lock.json changes

The lockfile cleanup removes yargs and its transitive dependencies:

  • yargs, yargs-parser, y18n, cliui, get-caller-file, require-directory, escalade

This is consistent with what bundlephobia reports for yargs — it pulls in several packages. The 105-line reduction in package-lock.json is appropriate.

Verdict

LGTM. The change is correct and safe:

  • No code references yargs
  • The package.json and lockfile are in sync
  • Author reports npm test passes, which is expected since yargs was never imported

No issues to flag.

@LuuOW LuuOW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical audit: Verified MCP server implementation for consistency with current SDK patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server-sequentialthinking Reference implementation for the Sequential Thinking MCP server - src/sequentialthinking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants