fix: report pre-init metadata errors - #1160
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
T-test
DaleSeo
marked this pull request as ready for review
August 9, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1157
Motivation and Context
Previously, a malformed 2026 inline-lifecycle opener caused
serve()to fail before sending any bytes to the client. As a result, stdio clients could wait without receiving a diagnostic, even though the same malformed metadata was reported as invalid params after negotiation. The server now reports any missing or malformed_metakeys with-32602before returning the existing initialization error.How Has This Been Tested?
Add tests.
Breaking Changes
None.
Types of changes
Checklist