feat: add Kotlin SDK BOM - #966
Open
original4422 wants to merge 1 commit into
Open
Conversation
Author
|
Hi @devcrocod, when you have a chance, would you mind reviewing this BOM artifact change and letting me know if any changes are needed? Thank you! |
Author
|
Hi @devcrocod, following up since the last review request—when you have a chance, could you please take another look and let me know whether this is ready to merge or needs changes? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kotlin-sdk-bomJava platformkotlin-sdk-core,kotlin-sdk-client, andkotlin-sdk-serverto the project versionThe module reuses the existing
mcp.publishingconvention, so its POM carries the same Maven Central metadata and signing setup as the other SDK artifacts. It publishes platform metadata and a POM, not a runtime JAR.Fixes #351
Validation
./gradlew :kotlin-sdk-bom:clean :kotlin-sdk-bom:build :kotlin-sdk-bom:generatePomFileForMavenPublication ktlintCheck detekt apiCheck --stacktrace --continue0.15.0./gradlew jvmTest :conformance-test:build :docs:build :kotlin-sdk-bom:build --max-workers 3 --continueA broader
./gradlew build --max-workers 3 --continue --rerun-taskscompleted the JVM suites and platform compilation until Apple native link tasks required Xcode, which is not installed in this environment (xcrun xcodebuild -versionexits 72). Those Apple link tasks are left to macOS CI.