Skip to content

Expose marine regions version - #83

Merged
irm-codebase merged 3 commits into
modelblocks-org:mainfrom
brynpickering:expose_marineregions_version
Aug 18, 2026
Merged

Expose marine regions version#83
irm-codebase merged 3 commits into
modelblocks-org:mainfrom
brynpickering:expose_marineregions_version

Conversation

@brynpickering

@brynpickering brynpickering commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Closes #82

Open Q: do we want to label output files with this version as we do with some of the others? It's unnecessary right now as we limit it to a single version.

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

@irm-codebase

Copy link
Copy Markdown
Collaborator

Thanks for the submission @brynpickering!
To maintain the principle of re-usability of 'harmonised' files, I'd say it's a good idea to label them with the requested version, yeah.

@irm-codebase irm-codebase left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

Only thing I suggest is moving from a 'hard cap' (version==2.0.0) to a more permissive 'lower cap' (version >= 2.x.x). This allows us and users to try updating the EEZ version without needing to update the module version.

Comment on lines 14 to 16
logs="resources/module/logs",
resources="resources/module/resources",
resources=temp("resources/module/resources"),
results="resources/module/results",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know you could pass temp() outside the call!
Does it work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this crept in from a test I did. I should delete it.

Comment thread workflow/scripts/download_harmonised_eez.py
Comment thread workflow/internal/config.schema.yaml Outdated
@irm-codebase
irm-codebase merged commit 820d6c6 into modelblocks-org:main Aug 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose EEZ versioning

2 participants