Skip to content

Update Charon submodule to v0.1.69#4660

Open
tautschnig wants to merge 1 commit into
model-checking:mainfrom
tautschnig:charon-update-v0.1.69-pr
Open

Update Charon submodule to v0.1.69#4660
tautschnig wants to merge 1 commit into
model-checking:mainfrom
tautschnig:charon-update-v0.1.69-pr

Conversation

@tautschnig

Copy link
Copy Markdown
Member

Advance the Charon pin from v0.1.68 (63f7749d) to v0.1.69 (485bd36e), the next step of the incremental effort to catch the pinned Charon up with upstream (the endgame is dropping scripts/charon-patch.diff entirely).

Charon v0.1.69 makes Vector::elem_count the way to obtain the number of non-empty slots (len is removed); adapt the tuple-field-projection translation in the LLBC backend accordingly.

Refresh scripts/charon-patch.diff so its hunks apply against the v0.1.69 sources (context-line drift only; the patch content is unchanged).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Advance the Charon pin from v0.1.68 (63f7749d) to v0.1.69 (485bd36e), the next
step of the incremental effort to catch the pinned Charon up with upstream
(the endgame is dropping scripts/charon-patch.diff entirely).

Charon v0.1.69 makes `Vector::elem_count` the way to obtain the number of
non-empty slots (`len` is removed); adapt the tuple-field-projection
translation in the LLBC backend accordingly.

Refresh scripts/charon-patch.diff so its hunks apply against the v0.1.69
sources (context-line drift only; the patch content is unchanged).

Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 20, 2026 00:22
@tautschnig
tautschnig requested a review from a team as a code owner July 20, 2026 00:22
@github-actions github-actions Bot added Z-EndToEndBenchCI Tag a PR to run benchmark CI Z-CompilerBenchCI Tag a PR to run benchmark CI labels Jul 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR advances the pinned Charon version to v0.1.69 and updates Kani’s LLBC backend to match the upstream API change where Vector::len is removed in favor of Vector::elem_count, ensuring tuple-field-projection translation continues to compute tuple arity correctly.

Changes:

  • Update the Charon dependency pin to v0.1.69 (including Cargo.lock).
  • Adapt LLBC tuple projection translation to use genargs.types.elem_count() instead of len().
  • Refresh scripts/charon-patch.diff so it applies cleanly against the v0.1.69 sources (context drift / metadata updates).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/charon-patch.diff Updates the patch file metadata/context so git apply continues to work against the new Charon sources.
kani-compiler/src/codegen_aeneas_llbc/mir_to_ullbc/mod.rs Switches tuple arity computation to elem_count() to match Charon v0.1.69’s Vector API.
Cargo.lock Bumps the resolved charon package version to 0.1.69.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@feliperodri feliperodri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it.

@feliperodri
feliperodri added this pull request to the merge queue Jul 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2026
@tautschnig
tautschnig added this pull request to the merge queue Jul 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-CompilerBenchCI Tag a PR to run benchmark CI Z-EndToEndBenchCI Tag a PR to run benchmark CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants