Repository navigation
Keep the browser's startup messages out of the login prompt, add prod environment (3.0.1) - #8
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
login-forumandlogin-googleopen the browser while the paste prompt is waiting, and the browser inherits modcli's stderr. GTK browsers print startup messages there, which land in the middle of the prompt:_open_browsernow points fd 2 at/dev/nullwhilewebbrowser.openspawns the browser, then restores it. The browser keeps/dev/nullas its stderr, so messages it prints afteropenreturns are dropped as well. The URL is still printed as a fallback.Also:
labsenvironment withprod(api.mod.audio,pipeline.mod.audio) and makesdevthe default.Testing
python:3.12-slimcontainer, with a fakexdg-openthat writes GTK messages immediately and one second later: before the change both messages appear after the prompt; with it, neither does, and modcli's own stderr works afterwards.pytest: 26 passed.pylint --errors-only modcli tests: clean.🤖 Generated with Claude Code